Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix icon names #17391

Merged
merged 2 commits into from
Jan 25, 2023
Merged

fix icon names #17391

merged 2 commits into from
Jan 25, 2023

Conversation

garrettbear
Copy link
Contributor

@garrettbear garrettbear commented Jan 24, 2023 •
edited
Loading

Explanation

A recent change to our list of Icons removed the term filled and outline, but some Icons were implemented before the recent PR. This is a hotfix for those icons.

Screenshots/Screencaps

See comments below

Before

See comments below

After

See comments below

Manual Testing Steps

yarn jest ui/components/component-library

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • [ x] Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@garrettbear garrettbear requested a review from a team as a code owner January 24, 2023 19:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [ce6f6a9]
Page Load Metrics (1265 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932681313617
domContentLoaded10131726124320598
load10131726126520799
domInteractive10131726124320598
Bundle size diffs
  • background: 0 bytes
  • ui: -58 bytes
  • common: 0 bytes

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/components/app/collectible-details/collectible-details.js
sourceCopied
? ICON_NAMES.COPY_SUCCESS_FILLED
: ICON_NAMES.COPY_FILLED
sourceCopied ? ICON_NAMES.COPY_SUCCESS : ICON_NAMES.COPY
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2023-01-24 at 2 44 49 PM

After
Screenshot 2023-01-24 at 2 44 59 PM

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/components/app/collectible-details/collectible-details.js
addressCopied
? ICON_NAMES.COPY_SUCCESS_FILLED
: ICON_NAMES.COPY_FILLED
addressCopied ? ICON_NAMES.COPY_SUCCESS : ICON_NAMES.COPY
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-24 at 2 46 11 PM

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/components/app/flask/snap-delineator/snap-delineator.js
@@ -31,7 +31,7 @@ export const SnapDelineator = ({ snapName, children }) => {
paddingTop={1}
paddingBottom={1}
>
<Icon name="snaps-filled" color={COLORS.INFO_DEFAULT} size={SIZES.SM} />
<Icon name="snaps" color={COLORS.INFO_DEFAULT} size={SIZES.SM} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2023-01-24 at 2 49 08 PM

After
Screenshot 2023-01-24 at 2 49 12 PM

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/components/component-library/banner-base/README.mdx
@@ -114,7 +114,7 @@ import { BannerBase, Icon, ICON_NAMES } from '../../component-library';

<BannerBase
title="Start accessory demo"
startAccessory={<Icon name={ICON_NAMES.INFO_FILLED} size={SIZES.LG} />}
startAccessory={<Icon name={ICON_NAMES.INFO} size={SIZES.LG} />}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2023-01-24 at 2 53 27 PM

After
Screenshot 2023-01-24 at 2 53 35 PM

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/components/component-library/banner-base/banner-base.js
@@ -68,7 +68,7 @@ export const BannerBase = ({
{onClose && (
<ButtonIcon
className="mm-banner-base__close-button"
iconName={ICON_NAMES.CLOSE_OUTLINE}
iconName={ICON_NAMES.CLOSE}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2023-01-24 at 2 54 15 PM

After
Screenshot 2023-01-24 at 2 54 22 PM

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/components/component-library/banner-base/banner-base.stories.js
@@ -92,7 +92,7 @@ DefaultStory.args = {
title: 'Title is sentence case no period',
children: "Description shouldn't repeat title. 1-3 lines.",
actionButtonLabel: 'Action',
startAccessory: <Icon name={ICON_NAMES.INFO_FILLED} size={SIZES.LG} />,
startAccessory: <Icon name={ICON_NAMES.INFO} size={SIZES.LG} />,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2023-01-24 at 2 53 27 PM

After
Screenshot 2023-01-24 at 2 53 35 PM

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/components/component-library/banner-base/banner-base.stories.js
@@ -165,5 +165,5 @@ StartAccessory.args = {
title: 'Start accessory demo',
children:
'The info icon on the left is passed through the startAccessory prop',
startAccessory: <Icon name={ICON_NAMES.INFO_FILLED} size={SIZES.LG} />,
startAccessory: <Icon name={ICON_NAMES.INFO} size={SIZES.LG} />,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2023-01-24 at 2 53 27 PM

After
Screenshot 2023-01-24 at 2 53 35 PM

garrettbear
garrettbear commented Jan 24, 2023
View reviewed changes
ui/pages/onboarding-flow/privacy-settings/privacy-settings.js
@@ -225,7 +225,7 @@ export default function PrivacySettings() {
e.preventDefault();
dispatch(showModal({ name: 'ONBOARDING_ADD_NETWORK' }));
}}
icon={<Icon name="add-outline" marginRight={2} />}
icon={<Icon name="add" marginRight={2} />}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
Screenshot 2023-01-24 at 2 56 24 PM

After
Screenshot 2023-01-24 at 2 56 41 PM

@garrettbear garrettbear self-assigned this Jan 24, 2023
@garrettbear garrettbear added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension IA/NAV labels Jan 24, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [ababf73]
Page Load Metrics (1337 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint972811334220
domContentLoaded98519531297273131
load100419531337281135
domInteractive98519531297273131
Bundle size diffs
  • background: 0 bytes
  • ui: -58 bytes
  • common: 0 bytes

georgewrmarshall
georgewrmarshall reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not too much work can we update them all to use the ICON_NAMES object?

@NidhiKJha NidhiKJha merged commit 23133a2 into develop Jan 25, 2023
@NidhiKJha NidhiKJha deleted the hotfix/icon-names branch January 25, 2023 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy NiranjanaBinoy is a code owner automatically assigned from MetaMask/extension-devs

@ryanml ryanml Awaiting requested review from ryanml

@rekmarks rekmarks Awaiting requested review from rekmarks

@darkwing darkwing Awaiting requested review from darkwing

Assignees

@garrettbear garrettbear

Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garrettbear @metamaskbot @georgewrmarshall @NidhiKJha